It depends a lot on your budget and what it is you really want to achieve. I've always used Magix Vegas since I pick it up in various Humble Bundles. It works really well for me as it has all the features that any professional really needs. There's some bells and whistles that aren't there for sure, but the price was right for me.
The thing is, it's not so much about the software used as it is your filming, editing and writing skills. Take a good look at most of the best YouTube channels and you'll quickly notice that most of them use simple effects and a lot of strait cuts. Their videos shine because they spend a lot of time making sure that they're polished long before they even get to the editing phase.
Whatever software you decide to use, remember that it's light years beyond what was available just a few decades ago and look at the quality of content that was produced. Besides, most people will overlook a lot of things if your videos have the content they want.
