3 Replies Latest reply on May 26, 2016 2:38 AM by dipak

    Uninitialized variable - should runtime hang?

    sandyandr

      My kernel simply hangs when I try to do something like this:

       

      var ushort4 vus4;

      var ushort vus;

      var int i;

       

      if (get_local_id(0) < ...) vus4 = (ushort4) (..., ..., ..., ...);

      ...

      for (i = 0; i < 4; i++) {

           vus = ...;

           vus4 = (ushort4) (vus4.yzw, vus);

      }

       

      Windows watchdog restarts the driver - on VLIW as well on GCN devices. The problem was that vus4 wasn't initialized for every workitem. I understand the reasons why such code is a problem for OpenCL - register allocation, etc.. Anyway, in a huge kernel it took quite a long time for me to find the cause of the problem - it'd be better if OpenCL runtime could avoid lock-ups in such situations somehow. Is it possible?

        • Re: Uninitialized variable - should runtime hang?
          dipak

          Hi,

          I didn't find any such issue when I checked the attached kernel code (similar as yours) with the latest Crimson driver 16.5.3.

           

          Regards,

            • Re: Uninitialized variable - should runtime hang?
              sandyandr

              You are right, sorry - the problem is somwhere deeper. Anyway, I gradually reduced my working kernel into this simpliest one - it securely hangs 15.7.1 Catalyst on HD5770 (last available for this device). Now I just can't find the real cause of the problem - any further changes to the code make it alive again. I know, it looks strange now, with unnecessary local mem barrier there and other, but it shouldn't hang the runtime anyway, how do you think? The kernel source code (too many arguments are there - you can wipe unnecessary out, I think):

               

              __constant sampler_t imageSampler = CLK_NORMALIZED_COORDS_FALSE | CLK_ADDRESS_NONE | CLK_FILTER_NEAREST;

               

              __kernel __attribute__((reqd_work_group_size(256, 1, 1))) void faultyKernel(

                uint gentime,

                __read_only image2d_t config,

                __read_only image2d_t info,

                __read_only image2d_t consts,

                __read_only image2d_t olddata,

                __read_only image2d_t middata,

                __read_only image2d_t newdata,

                __write_only image2d_t output,

                __write_only image2d_t stats,

                __global uint * adata,

                __global uint * bdata,

                __global uint * cdata,

                __global uint * ddata)

              {

               

                uint w = get_local_id(0);

                uint g = get_global_id(1);

                uint vui;

                uint4 vui4;

                int2 coord;

                int i;

               

                adata[w] = 0;

                if (w < 8) bdata[w] = 0;

               

                if (g + 1 != 0) {

                  if (w < 8) {

                    coord.y = 0;

                    coord.x = w;

                    vui4 = read_imageui(newdata, imageSampler, coord);

                    cdata[w] = vui4.z;

                  }

                }

               

                if (g + 1 != 0) {

                  barrier(CLK_LOCAL_MEM_FENCE);

                  //vui4 = (uint4)(0, 0, 0, 0);

                  for (i = 0; i < 4; i++) {

                    vui = 5;

                    vui4 = (uint4) (vui4.yzw, vui);

                  }

                }

               

              }

                • Re: Uninitialized variable - should runtime hang?
                  dipak

                  Thank you for your effort to make this reproducible test-case. However, it would be more helpful if you can provide the complete test-project (including the host-side code) so that we can run it here.

                  BTW, did you check the code on other setups with more recent drivers? If so, did you observe the same issue there or is it only specific to this HD5770?

                   

                  Regards,